Hide Service UI Configure button only in Scope #2766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaron7
approved these changes
Jul 28, 2017
There was a problem hiding this comment.
LGTM - https://github.com/weaveworks/service-ui/pull/841, which will merge soon, will remove the configure button from all pages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By mistake, #2703 introduced a change that made CONFIGURE button disappear from all the pages in Weave Cloud, instead of just hidding it in configured Scope.
I'm pretty sure @rade wrote somewhere he thinks it's ok to hide the button in Scope to make room for the timeline, but I couldn't find the source to quote him :)