Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Resource view nodes clickable #2679

Merged
merged 3 commits into from
Jul 25, 2017
Merged

Conversation

fbarl
Copy link
Contributor

@fbarl fbarl commented Jul 4, 2017

Resolves #2663 by making resource view nodes selectable. Ideally, we would also zoom into the selected node like we do in the graph view, but the animation there is a bit more involved, so it shouldn't be a blocker for this action that feels very basic.

@fbarl fbarl self-assigned this Jul 4, 2017
@fbarl fbarl requested a review from davkal July 4, 2017 16:49
@fbarl fbarl force-pushed the make-resource-nodes-clickable branch 2 times, most recently from a6b6bf0 to c9ca3d5 Compare July 7, 2017 17:00
@fbarl
Copy link
Contributor Author

fbarl commented Jul 7, 2017

@davkal ping

@fbarl fbarl force-pushed the make-resource-nodes-clickable branch from c9ca3d5 to 5a4429d Compare July 20, 2017 13:30
@rndstr
Copy link
Contributor

rndstr commented Jul 24, 2017

I played with it and it works well!

Copy link
Contributor

@davkal davkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, works well.

Two nits:

  • clicking on the background should close the selection
  • selected-ness in other views is rendered as a light blue aura, as opposed to low opacity (low opacity being reserved for non-selected entities)

@fbarl fbarl force-pushed the make-resource-nodes-clickable branch from 5a4429d to 59129fa Compare July 25, 2017 15:07
@fbarl fbarl merged commit 8f1fdeb into master Jul 25, 2017
@fbarl fbarl deleted the make-resource-nodes-clickable branch July 27, 2017 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants