Use new k8s go client #2659
Merged
Use new k8s go client #2659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekimekim
approved these changes
Jun 29, 2017
2opremio
force-pushed
the
use-new-k8s-go-client
branch
from
78fa6c7 to
e3bc6fe
Compare
|
Rebased due to conflict in |
|
Tests started failing after I rebased: |
|
It's failed with 3 different error messages across 3 runs. And I can't run the integration tests locally, apparently they use GCE and I need creds. |
You should be able to run the tests against local VMs. If that is not working, please raise an issue and fix it. |
added 7 commits
July 3, 2017 20:20
This namely involved importing new libraries and using the new Clientset. Changes worth mentioning: * The new kubernetes library doesn't provide StoreToLister wrappers, so now I am going the casting directly. * Deleting the pods and getting their logs is done in a cleaner way (using the Clientset instead of the lower-level RESTclient).
2opremio
force-pushed
the
use-new-k8s-go-client
branch
from
e3bc6fe to
93b0bc8
Compare
|
Rebased again to see if the error was transient (no other PR seems to be suffering from this) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This namely involved importing new libraries and using the new Clientset.
Changes worth mentioning:
StoreToLister wrappers, so now I am doing the casting directly.Clientset instead of the lower-level RESTclient).
HostNetworkis now inlined in the pod specAfter merging this PR we should probably create a new one to replace the raw
cache.Stores by the newerSharedIndexInformer. This will allow us to:EventStore(we can set event handlers directly with the Informer interface)cache.Stores and castings (we can create listers like PodLister using the indexer).TODO: