-
Notifications
You must be signed in to change notification settings - Fork 712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show multiple relatives in the nodes-grid view #2648
Conversation
@fbarl ping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple of technical comments but otherwise very nicely done! :)
@@ -26,3 +26,7 @@ export function moveElement(array, from, to) { | |||
} | |||
return insertElement(removeElement(array, from), to, array[from]); | |||
} | |||
|
|||
export function intersperse(items, value) { |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
@@ -1,5 +1,10 @@ | |||
import React from 'react'; | |||
import classNames from 'classnames'; | |||
import groupBy from 'lodash/groupBy'; | |||
import forEach from 'lodash/forEach'; | |||
import mapValues from 'lodash/mapValues'; |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
||
forEach(relativesByTopologyId, (columnData, topologyId) => { | ||
values[topologyId] = columnData; | ||
}); |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
5d16501
to
bc70ab1
Compare
bc70ab1
to
ee55d17
Compare
Fixes #2627