Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show multiple relatives in the nodes-grid view #2648

Merged
merged 2 commits into from
Jul 5, 2017

Conversation

foot
Copy link
Contributor

@foot foot commented Jun 26, 2017

Fixes #2627

@foot foot requested a review from fbarl June 26, 2017 11:28
@rade
Copy link
Member

rade commented Jun 29, 2017

@fbarl ping

Copy link
Contributor

@fbarl fbarl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of technical comments but otherwise very nicely done! :)

@@ -26,3 +26,7 @@ export function moveElement(array, from, to) {
}
return insertElement(removeElement(array, from), to, array[from]);
}

export function intersperse(items, value) {

This comment was marked as abuse.

@@ -1,5 +1,10 @@
import React from 'react';
import classNames from 'classnames';
import groupBy from 'lodash/groupBy';
import forEach from 'lodash/forEach';
import mapValues from 'lodash/mapValues';

This comment was marked as abuse.


forEach(relativesByTopologyId, (columnData, topologyId) => {
values[topologyId] = columnData;
});

This comment was marked as abuse.

This comment was marked as abuse.

@foot foot force-pushed the 2627-node-grid-multiple-relatives branch from 5d16501 to bc70ab1 Compare July 3, 2017 15:53
@foot foot force-pushed the 2627-node-grid-multiple-relatives branch from bc70ab1 to ee55d17 Compare July 4, 2017 08:42
@foot foot merged commit 899c708 into master Jul 5, 2017
@foot foot deleted the 2627-node-grid-multiple-relatives branch July 5, 2017 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants