ensure connections from /proc/net/tcp{,6} get the right pid #2639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rade
force-pushed
the
2638-connection-pid-pollution
branch
from
ec8d7fc to
c29974f
Compare
|
Note that with this change, the troublesome connection from #2638 doesn't show up at all, which arguably is the correct outcome, given that one of the connection ends belongs to a short-lived process that has since vanished. |
|
tests are failing because of #2640. |
ProcNet.Next does not allocate Connection structs, for efficiency. Instead it always returns a *Connection pointing to the same instance. As a result, any mutations by the caller to struct elements that aren't actually set by ProcNet.Next, in particular Connection.Proc, are carried across to subsequent calls. This had hilarious consequences: connections referencing an inode which we hadn't come across during proc walking would be associated with the process corresponding to the last successfully looked up inode. The fix is to clear out the garbage left over from previous calls. Fixes #2638.
rade
force-pushed
the
2638-connection-pid-pollution
branch
from
c29974f to
30e0444
Compare
|
Really good catch |
2opremio
approved these changes
Jun 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ProcNet.Nextdoes not allocateConnectionstructs, for efficiency. Instead it always returns a*Connectionpointing to the same instance. As a result, any mutations by the caller to struct elements that aren't actually set byProcNet.Next, in particularConnection.Proc, are carried across to subsequent calls.This had hilarious consequences: connections referencing an inode which we hadn't come across during proc walking would be associated with the process corresponding to the last successfully looked up inode.
The fix is to clear out the garbage left over from previous calls.
Fixes #2638.