Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add app capabilities to /api endpoint #2575

Merged
merged 2 commits into from
Jun 8, 2017
Merged

Add app capabilities to /api endpoint #2575

merged 2 commits into from
Jun 8, 2017

Conversation

2opremio
Copy link
Contributor

@2opremio 2opremio commented Jun 8, 2017

The first capability is whether there is report persistence, needed to conditionally enable time controls in the UI ( #2524 )

@2opremio 2opremio requested a review from rndstr June 8, 2017 13:03
Copy link
Contributor

@rndstr rndstr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one linter issue, lgtm otherwise

(I could imagine having a test that confirms capabilities configured is equal to json response in /api)

@@ -14,12 +14,15 @@ const (
ScopeProbeVersionHeader = "X-Scope-Probe-Version"
)

const ReportPersistenceCapability = "report_persistence"

This comment was marked as abuse.

@fbarl fbarl mentioned this pull request Jun 8, 2017
@2opremio 2opremio merged commit 6913d49 into master Jun 8, 2017
@2opremio 2opremio deleted the app-capabilites branch June 8, 2017 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants