Add ContainerImage topology and use it to build the Container By Image graph. #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomwilkie
force-pushed
the
230-container-image-topology
branch
from
ea855d2 to
f88a946
Compare
…e graph. This makes container image details show the containers (and processes) correctly. Also: - introduces a 'test' package, moved Diff function there. - adds some tests for this new rendered view.
tomwilkie
force-pushed
the
230-container-image-topology
branch
from
f88a946 to
25ca0c0
Compare
This was referenced Jun 18, 2015
Closed
| @@ -109,6 +111,6 @@ func TestMakeDetailedNode(t *testing.T) { | |||
| }, | |||
| } | |||
| if !reflect.DeepEqual(want, have) { | |||
| t.Errorf("%s", diff(want, have)) | |||
| t.Errorf("%s", test.Diff(want, have)) | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
LGTM |
tomwilkie
added a commit
that referenced
this pull request
Jun 18, 2015
Add ContainerImage topology and use it to build the Container By Image graph.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes container image details show the containers (and processes) correctly.
Fixes #230
Also: