-
Notifications
You must be signed in to change notification settings - Fork 712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add daemonsets #2526
Add daemonsets #2526
Conversation
probe/kubernetes/daemonset.go
Outdated
selector, err := unversioned.LabelSelectorAsSelector(d.Spec.Selector) | ||
if err != nil { | ||
// TODO(paulbellamy): Remove the panic! | ||
panic(err) |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
render/pod.go
Outdated
// in (for now) a very naive way. | ||
var ReplicaGroupRenderer = MakeReduce( | ||
DeploymentRenderer, | ||
DaemonSetRenderer, |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
Done with the review: Minor code comment and a fundamental design question. I don't mind going ahead with this a refining it later, but as a kubernetes user, I find the ReplicaGroup view a bit odd. |
(addressing design question at the top level instead of at the specific comment) Yeah, I agree. The view is confusing and right now badly named. The As I see it, we have three options. In my order of preference:
|
I would go for (1) as well. @rade ? |
go for (1), but make sure there is a follow up, in particular peeling off bits from #552, specifically replacing (nearly) all existing views with a view that shows you everything in existence, at the highest level of abstraction in which it has a representation. |
4cc432c
to
9055edf
Compare
I've removed the combined view parts and otherwise rebased fixups. PTAL. |
Looks good. There is still a comment on a TODO |
9055edf
to
c0751cd
Compare
Rebased and resolved conflicts with #2528. |
I am exceptionally merging this myself (and not the PR creator) to move forward with the release |
Fixes #1444
This adds collection of daemonset info to the probe,
and two new views to the app. One showing only daemonsets,
one showing deployments + daemonsets.
This is too many views (see discussion in #1444), but was useful for initial debugging - we can remove the daemonsets view before merging.
We need to decide how we are going to present this new 'combined view' to the user in a way that makes it obvious what's going on. For now I've labelled it 'Replica groups' but that's not good enough.