Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add weavenet metrics to billing #2504

Merged
merged 2 commits into from
May 10, 2017
Merged

Add weavenet metrics to billing #2504

merged 2 commits into from
May 10, 2017

Conversation

leth
Copy link
Contributor

@leth leth commented May 8, 2017

This is intended to give some insights into adoption among weave cloud users

@leth leth requested review from paulbellamy and tomwilkie May 8, 2017 12:10
@leth
Copy link
Contributor Author

leth commented May 8, 2017

The build for this is going to fail until the vendor-ed code is updated to contain weaveworks/billing-client#5

hasNet := false
for _, n := range r.Overlay.Nodes {
overlayType, _ := report.ParseOverlayNodeID(n.ID)
if overlayType == report.WeaveOverlayPeerPrefix {

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

@2opremio
Copy link
Contributor

2opremio commented May 8, 2017

The build for this is going to fail until the vendor-ed code is updated to contain weaveworks/billing-client#5

Gotcha. Please ping me once the vendored code is updated

@leth
Copy link
Contributor Author

leth commented May 8, 2017 via email

@tomwilkie
Copy link
Contributor

I'd heard the go convention was to have one exit point

Really? Where did you read this? I'd say quite the opposite.

@leth
Copy link
Contributor Author

leth commented May 9, 2017

I think it was something I read ages ago; I may have imagined it. I'll simplify :)

@leth leth force-pushed the weavenet_metrics branch from 5d18238 to 4210b30 Compare May 9, 2017 14:23
@leth leth force-pushed the weavenet_metrics branch from b8d10e3 to 9fded9d Compare May 9, 2017 15:33
@leth
Copy link
Contributor Author

leth commented May 9, 2017

@2opremio I've updated billing-client

@leth leth merged commit 860dfb7 into master May 10, 2017
@leth leth deleted the weavenet_metrics branch May 10, 2017 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants