Added mixpanel tracking for some basic events #2462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbarl
force-pushed
the
add-mixpanel-tracking
branch
from
07606f1 to
7e5eca7
Compare
fbarl
changed the title
foot
approved these changes
Apr 26, 2017
| // If the search query is parsable, pin it when ENTER key is hit. | ||
| if (ev.keyCode === ENTER_KEY_CODE && parseQuery(this.props.searchQuery)) { | ||
| trackMixpanelEvent('scope.search.query.pin', { | ||
| query: this.props.searchQuery, |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
| handleFocus() { | ||
| this.props.focusSearch(); | ||
| } | ||
|
|
||
| doSearch(value) { | ||
| if (value !== '') { | ||
| trackMixpanelEvent('scope.search.query.change', { | ||
| query: value, |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
fbarl
force-pushed
the
add-mixpanel-tracking
branch
from
7e5eca7 to
9644b97
Compare
fbarl
force-pushed
the
add-mixpanel-tracking
branch
from
78b7728 to
8eaf48a
Compare
|
@foot I addressed your comment and also added some tracking for All these changes were rather small so I'll merge this PR after the tests pass without your second look at it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #2460 by making use of Service UI's configured
window.mixpanelvariable directly.Tracked events
scope.layout.refresh.clickscope.layout.selector.clickscope.layout.selector.keypressscope.metric.selector.pin.clickscope.metric.selector.pin.next.keypressscope.metric.selector.pin.previous.keypressscope.metric.selector.unpin.clickscope.metric.selector.unpin.keypressscope.node.clickscope.node.relative.clickscope.search.query.changescope.search.query.pinscope.topology.option.clickscope.topology.selector.clickMost of them have the active topology and view mode (layout) props attached to them to have some context of where the events are coming from. I checked it on the mixpanel dashboard and it seems to work nicely!
Other changes
hitEnteraction withpinSearchwhich gets called directly from thesearch.js, since we only need to handle the ENTER key press from the search bar.