don't lie about reachable address #2443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when app.http.address is specified. Instead just tell the user that scope is reachable where they said. Also, complain when the address is specified on D4M since there are a bunch of hard-coded port 4040 in place for that. Fixes #1190.
ekimekim
approved these changes
Apr 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when
--app.http.addressis specified. Instead just tell the user that scope is reachable where they said.Also, complain when the address is specified on D4M since there are a bunch of hard-coded port 4040 in place for that.
Fixes #1190.
I did consider a) extracting the address argument and constructing a more precise "reachable at" message, and b) respecting the address on D4M, but decided against both on cost/benefit grounds.