Make various anonymous fields named #2419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anonymous fields make any methods on the inner object visible on the outer, so they should only be used when the outer is-a inner.
2opremio
approved these changes
Apr 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Anonymous fields make any methods on the inner object visible on the outer, so they should only be used when the outer is-a inner.
I wanted to make this change after spending several hours puzzled why the code ended up in a particular method that didn't have anything to do with what it was being called upon.
To create this PR I looked at every
structin the Scope codebase, apart from unit tests. There are very few anonymous fields overall, with some such asMutexcorrectly used. In a couple of cases I gave the benefit of the doubt.