Decode via byte slice for memcache and file read #2331
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is more efficient, since the decoder can read field names in-place.
It also appears to be absolutely faster.
On master, decoding 75 reports from file, totalling 16MB compressed:
On this branch, calling
NewDecoderBytes
but not updating the msgpack libarary:And, if you update the msgpack library so it actually does the in-place reading:
Note
readReport
decompresses rather than havingReadBytes
do it, to avoid creating an intermediate copy of the entire compressed file.