Changed ui-build-pkg job to use a docker container #2281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ekimekim Could you review when you get a sec? |
jpellizzari
force-pushed
the
ui-pkg-fix
branch
from
d26570e to
175c64a
Compare
|
@ekimekim Updated with your IRL feedback |
ekimekim
approved these changes
Feb 24, 2017
Makefile
Outdated
| @@ -1,4 +1,4 @@ | |||
| .PHONY: all deps static clean client-lint client-test client-sync backend frontend shell lint ui-upload | |||
| .PHONY: all deps static clean client-lint client-test client-sync backend frontend shell lint ui-upload | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
jpellizzari
force-pushed
the
ui-pkg-fix
branch
from
175c64a to
efdd8e4
Compare
|
Very worrying that my editor would add in whitespace. It removes it by default on save, but I haven't seen it add it in like that before... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the ui-build-pkg job to use the existing SCOPE_UI_BUILD_IMAGE to compile an npm module and place it on S3.