Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add loading indicator on topology option change #2272

Merged
merged 1 commit into from
Feb 23, 2017

Conversation

jpellizzari
Copy link
Contributor

Missed in #2232

Adds the loading indicator if changing topology options is taking a long time. Otherwise, its a blank screen.

@fbarl Mind taking a look?

@jpellizzari jpellizzari requested a review from fbarl February 23, 2017 00:41
Copy link
Contributor

@fbarl fbarl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are actually two more places where we do state.update('nodes', nodes => nodes.clear()) instead of clearNodes(state); they are in actions OPEN_WEBSOCKET and ROUTE_TOPOLOGY. Do you think any of these two should be using clearNodes instead?

@jpellizzari jpellizzari force-pushed the loading-topology-filters branch from 27ab9e8 to 5f468cc Compare February 23, 2017 18:17
@jpellizzari
Copy link
Contributor Author

@fbarl Nice catch. I added clearNodes to ROUTE_TOPOLOGY, since that is checking for a topology change. As far as I can tell, the OPEN_WEBSOCKETS action is just clearing the cache, so no need to apply the "loading" logic. I left that one as is.

@jpellizzari jpellizzari merged commit a90858f into master Feb 23, 2017
@jpellizzari jpellizzari deleted the loading-topology-filters branch February 23, 2017 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants