Rename ECS Service node ids to be cluster;serviceName #2186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekimekim
force-pushed
the
mike/ecs/clusterise-service-ids
branch
from
04b0682 to
00ba689
Compare
|
Failing test is due to integration test that's broken on master. |
2opremio
reviewed
Feb 3, 2017
| return "", "", false | ||
| } | ||
| // In previous versions, ECS Service node IDs were of form serviceName + "<ecs_service>". | ||
| // For backwards compatibility, we should still return a sensical serviceName for these cases. |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This is important for two reasons: * It prevents nasty false-equality bugs when two different services from different ECS clusters are present in the same report * It allows us to retrieve the cluster and service name - all the info we need to look up the service - using only the node ID. This matters, for example, when trying to handle a control request.
ekimekim
force-pushed
the
mike/ecs/clusterise-service-ids
branch
from
00ba689 to
fad3e88
Compare
|
ptal |
2opremio
approved these changes
Feb 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is important for two reasons:
are present in the same report
using only the node ID. This matters, for example, when trying to handle a control request.
We deal with maintaining backwards compatability with a special case when parsing the IDs.
Partially fixes #2063