Initialize USERNS_HOST variable #2176

2opremio · 2017-02-01T14:48:58Z

scope

@@ -27,6 +27,7 @@ WEAVESCOPE_DOCKER_ARGS=${WEAVESCOPE_DOCKER_ARGS:-}
 #  "Cannot share the host's network namespace when user namespaces are enabled" for `docker run --net=host`
 # To avoid above errors, use `--userns=host` option to let container use host User Namespace.
 # This option(saved in $USERNS_HOST) will be inserted ONLY IF docker support `--userns` option.
+USERNS_HOST=""


rade · 2017-02-01T15:19:38Z

LGTM, provided you have actually run this on an old and new docker.

2opremio · 2017-02-01T15:26:15Z

provided you have actually run this on an old and new docker.

Yep, I've run it in Circle (and tests pass)

Initialize USERNS_HOST variable

36da3cd

rade reviewed Feb 1, 2017

View reviewed changes

2opremio merged commit b25417e into master Feb 1, 2017

2opremio deleted the 2175-initialize-userns branch February 1, 2017 15:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Initialize USERNS_HOST variable #2176

Initialize USERNS_HOST variable #2176

2opremio commented Feb 1, 2017

This comment was marked as abuse.

This comment was marked as abuse.

rade commented Feb 1, 2017

2opremio commented Feb 1, 2017 •

edited

Loading

Initialize USERNS_HOST variable #2176

Initialize USERNS_HOST variable #2176

Conversation

2opremio commented Feb 1, 2017

This comment was marked as abuse.

This comment was marked as abuse.

rade commented Feb 1, 2017

2opremio commented Feb 1, 2017 • edited Loading

2opremio commented Feb 1, 2017 •

edited

Loading