Use Sass instead of Less #2141
Merged
Use Sass instead of Less #2141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks fine to me |
jpellizzari
force-pushed
the
convert-to-sass
branch
3 times, most recently
from
1296c84 to
fdf90a0
Compare
davkal
reviewed
Jan 20, 2017
| "html-webpack-plugin": "2.24.1", | ||
| "http-proxy-rules": "1.0.1", | ||
| "immutable-devtools": "0.0.7", | ||
| "jest-cli": "17.0.3", | ||
| "json-loader": "0.5.4", | ||
| "less": "2.7.1", | ||
| "less-loader": "2.2.3", | ||
| "node-sass": "^3.13.1", |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
| "postcss-loader": "1.2.0", | ||
| "react-addons-perf": "15.4.1", | ||
| "redux-devtools": "3.3.1", | ||
| "redux-devtools-dock-monitor": "1.1.1", | ||
| "redux-devtools-log-monitor": "1.1.1", | ||
| "sass-loader": "^4.1.1", |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
| }, | ||
| { | ||
| test: /\.(scss|css)$/, | ||
| loader: 'style-loader!css-loader!sass-loader' |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
Works well. Small issues:
Before After |
#2138? I am guessing this PR was branched prior to the fix. |
jpellizzari
force-pushed
the
convert-to-sass
branch
from
a9d6b1a to
cb48627
Compare
jpellizzari
force-pushed
the
convert-to-sass
branch
from
cb48627 to
ee69f77
Compare
|
@davkal updated with the matched-text styles fixed, xterm warning suppressed, and post-css added back in. |
|
Ping @davkal please review after my changes. |
foot
reviewed
Jan 24, 2017
| @body-background-color: linear-gradient(30deg, @background-color 0%, @background-lighter-color 100%); | ||
| @label-background-color: fade(@background-average-color, 70%); | ||
| $body-background-color: linear-gradient(30deg, $background-color 0%, $background-lighter-color 100%); | ||
| $label-background-color: fade-out($background-average-color, .7); |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
| color: @text-tertiary-color; | ||
| background-color: fade(@background-average-color, 90%); | ||
| color: $text-tertiary-color; | ||
| background-color: fade-out($background-average-color, .9); |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
| } | ||
|
|
||
| } | ||
|
|
||
| .search-item { | ||
| background-color: fade(@weave-blue, 20%); | ||
| border-radius: @border-radius / 2; | ||
| background-color: fade-out($weave-blue, .2); |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
LGTM! |
jpellizzari
force-pushed
the
convert-to-sass
branch
from
ee69f77 to
50b84fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for #2133
Changes the Less files to Sass. We are standardizing around Sass on other projects.
@davkal and @bowenli Please review, specifically for styling regressions.