Rename Table model to PropertyList
#2100
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbarl
force-pushed
the
node-details-generic-table-support
branch
4 times, most recently
from
8e51f80 to
8269569
Compare
fbarl
force-pushed
the
node-details-generic-table-support
branch
from
8269569 to
0c6ecf7
Compare
fbarl
changed the title
Table model to PropertyList
2opremio
reviewed
Dec 21, 2016
| WeavePluginTableID = "weave_plugin_table" | ||
| WeavePluginStatus = "weave_plugin_status" | ||
| WeavePluginDriver = "weave_plugin_driver" | ||
| WeaveConnectionsListPrefix = "weave_connections_list_" |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
2opremio
reviewed
Dec 21, 2016
| Metadata []report.MetadataRow `json:"metadata,omitempty"` | ||
| Parents []Parent `json:"parents,omitempty"` | ||
| Metrics []report.MetricRow `json:"metrics,omitempty"` | ||
| PropertyLists []report.PropertyList `json:"propertyLists,omitempty"` |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
2opremio
reviewed
Dec 21, 2016
| Controls `json:"controls,omitempty"` | ||
| MetadataTemplates `json:"metadata_templates,omitempty"` | ||
| MetricTemplates `json:"metric_templates,omitempty"` | ||
| PropertyListTemplates `json:"property_list_templates,omitempty"` |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a first step towards #1980, I renamed
TabletoPropertyListto clear the room for introducing a real generic multi-column table.