Reapplied all the eslint upgrade changes #2089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbarl
force-pushed
the
reapply-eslint-update
branch
2 times, most recently
from
702d54c to
66b8ff8
Compare
fbarl
force-pushed
the
reapply-eslint-update
branch
from
66b8ff8 to
e345f42
Compare
2opremio
pushed a commit
that referenced
this pull request
Dec 15, 2016
Reapplied all the eslint upgrade changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR re-introduces all the changes from #2058 that were rolled back as frontend.dev.weave.works UI broke after merging with master.
As a temporary hack that solves the issue, I moved
font-awesome-webpacklibrary fromdependenciestodevDependenciesinpackage.json. See #2090 for discussion on the proper solution.