-
Notifications
You must be signed in to change notification settings - Fork 712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add control status icon to Terminal header #2087
Conversation
a27319c
to
0ad48d8
Compare
Slick! Like the design.
|
return ( | ||
<span | ||
style={{marginRight: '8px', width: '14px'}} | ||
className={classNames('fa', {[`fa-${icon}`]: icon})} |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
0ad48d8
to
2b83ebd
Compare
@foot Updated to use the 'icon' field of the control. Thanks, that's much better. |
Nice. There's a bit of awkward implicitness in how we do the url state stuff. As the entire
But actually its not the worst thing in the world, we might need that info in the future. We have another ticket #1727 for tightening up the url state. LGTM! |
Implements #1982
This change will indicate the control status of the terminal. For example, if you are using the
exec
control a terminal icon will appear in the upper left (same for the 'attach' command):The icon is tightly coupled to the human name of the controls: "Attach" and "Exec shell". This will break if we ever change those values. If there is a different value to lookup (like an ID) that might be better.
@foot could you review please?