Improve plugin errors tooltip #2022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We tend to have more descriptive commit messages, rather than just referencing an issue number. |
fbarl
force-pushed
the
fix-plugins-tooltip
branch
2 times, most recently
from
e773a68 to
fbb8bbc
Compare
fbarl
changed the title
|
Triggered both on click and on hover:
I also added some opacity to the footer background, so that the it's readable when it floats above the nodes texts. |
|
Nice one.
Please change the commit message too! |
foot
reviewed
Nov 24, 2016
| @@ -187,11 +188,14 @@ h2 { | |||
| } | |||
|
|
|||
| .footer { | |||
| padding: @footer-padding; | |||
| margin: -@footer-padding; | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
Other than that LGTM |
fbarl
force-pushed
the
fix-plugins-tooltip
branch
from
2130f49 to
c110e32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1905 - Plugin errors are difficult to view