Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give time to the overlay test backoff collectors to finish #1995

Merged
merged 1 commit into from
Nov 8, 2016

Conversation

2opremio
Copy link
Contributor

@2opremio 2opremio commented Nov 8, 2016

Not the most elegant/robust solution but it solves the problem without adding
extra methods to the backoff interface (only to check if they are ready from
tests).

Fixes #1984

Not the most elegant/robust solution but it solves the problem without adding
extra methods to the backoff interface (only to check if they are ready from
tests).
@ekimekim
Copy link
Contributor

ekimekim commented Nov 8, 2016

test failure looks unrelated?
otherwise LGTM, as much as I hate magic sleeps.

@2opremio 2opremio merged commit c6fe3b8 into master Nov 8, 2016
@2opremio 2opremio deleted the 1984-flaky-overlay-test branch November 8, 2016 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants