middleware/errorhandler: Implement Hijacker so it works with ws proxy #1971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some details please. What is the user-visible impact of the problem this is fixing, and since when has it been present? |
|
No scope user impact - this middleware is only used by authfe in the service. In the service, this bug means that we can't use the admin scope instance, and has been in dev and prod since late last week. This only affects the admin endpoints, and scope is the only admin endpoint to use websockets. |
2opremio
reviewed
Nov 4, 2016
| @@ -78,3 +81,14 @@ func (i *errorInterceptor) Write(data []byte) (int, error) { | |||
| } | |||
| return len(data), nil | |||
| } | |||
|
|
|||
| // errorInterceptor also implements net.Hijacker, to let the downstream Handler | |||
| // hijack the connection. This is needed by the app-mapper's proxy. | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lack of this was causing 500s when errorhandler-wrapped requests were hijacked, such as for websocket proxying