Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix linter error for string in context.WithValue #1921

Merged
merged 1 commit into from
Oct 20, 2016
Merged

Fix linter error for string in context.WithValue #1921

merged 1 commit into from
Oct 20, 2016

Conversation

asymmetric
Copy link
Contributor

golang/lint#245 introduced a new requirement that keys passed to context.WithValue may not be basic types, but custom ones.

Cfr. discussion.

Comment for contextKey copied from Docker.

@rade rade mentioned this pull request Oct 19, 2016
Merged
@2opremio 2opremio merged commit 8c70630 into weaveworks:master Oct 20, 2016
@asymmetric asymmetric deleted the lint-ctx-key branch October 20, 2016 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asymmetric @2opremio