Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add timeouts to the probe http client #1920

Merged
merged 2 commits into from
Oct 13, 2016
Merged

Add timeouts to the probe http client #1920

merged 2 commits into from
Oct 13, 2016

Conversation

paulbellamy
Copy link
Contributor

@paulbellamy paulbellamy commented Oct 12, 2016 •
edited
Loading

Probe side of: #1917

TODO

  • Try this out

@tomwilkie
Copy link
Contributor

Checkout https://github.com/hashicorp/go-cleanhttp

@paulbellamy paulbellamy force-pushed the probe-client-timeouts branch from bf0223f to 002770d Compare October 13, 2016 08:45
@tomwilkie
Copy link
Contributor

LGTM! I'll hold off merging #1917 until this is deployed and we can see that it works.

@paulbellamy paulbellamy merged commit 8da5ca3 into master Oct 13, 2016
@paulbellamy paulbellamy deleted the probe-client-timeouts branch October 13, 2016 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tomwilkie tomwilkie

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulbellamy @tomwilkie