Allow users to specify conntrack buffer size. #1896

tomwilkie · 2016-09-26T17:59:09Z

So they can work around the ENOBUFFs problems.

probe/endpoint/conntrack_internal_test.go

@@ -13,6 +13,7 @@ import (
 )

 const conntrackCloseTag = "</conntrack>\n"
+const bufferSize = 1024 * 1024


prog/probe.go

@@ -152,7 +152,7 @@ func probeMain(flags probeFlags) {
 		defer dnsSnooper.Stop()
 	}

-	endpointReporter := endpoint.NewReporter(hostID, hostName, flags.spyProcs, flags.useConntrack, flags.procEnabled, flags.procRoot, scanner, dnsSnooper)
+	endpointReporter := endpoint.NewReporter(hostID, hostName, flags.spyProcs, flags.useConntrack, flags.procEnabled, flags.procRoot, flags.conntrackBufferSize, scanner, dnsSnooper)


2opremio · 2016-09-26T18:04:31Z

Minor comment/suggestion. Otherwise LGTM

2opremio · 2016-09-26T19:10:24Z

LGTM

prog/main.go

@@ -197,6 +199,7 @@ func main() {

 	// Proc & endpoint
 	flag.BoolVar(&flags.probe.useConntrack, "probe.conntrack", true, "also use conntrack to track connections")
+	flag.IntVar(&flags.probe.conntrackBufferSize, "probe.conntrack.buffersize", 208*1024, "conntrack buffer size")


rade

^

tomwilkie · 2016-09-27T01:30:12Z

Yeah I read it off the Dev cluster and my mini kube VM.

On Monday, 26 September 2016, Matthias Radestock [email protected]
wrote:

@rade commented on this pull request.

In prog/main.go #1896:

@@ -197,6 +199,7 @@ func main() {

// Proc & endpoint
flag.BoolVar(&flags.probe.useConntrack, "probe.conntrack", true, "also use conntrack to track connections")

flag.IntVar(&flags.probe.conntrackBufferSize, "probe.conntrack.buffersize", 208*1024, "conntrack buffer size")

looks like that's the default, on some Linuxes at least...

$ cat /proc/sys/net/core/rmem_default
212992

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
#1896, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAbGhVMUUqxpgQ8KHebZGRwtabOEqpKUks5quGRSgaJpZM4KG0K2
.

Allow users to specify conntrack buffer size.

81fe13d

2opremio reviewed Sep 26, 2016

View reviewed changes

tomwilkie added 2 commits September 26, 2016 11:06

Fix tests.

b2c86a8

Use a config struct.

d3bbdc6

tomwilkie merged commit b130f1b into master Sep 26, 2016

tomwilkie deleted the conntrack-buffersize branch September 26, 2016 19:08

tomwilkie mentioned this pull request Sep 26, 2016

Conntrack loses events due to ENOBUFS #1137

Closed

rade reviewed Sep 27, 2016

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow users to specify conntrack buffer size. #1896

Allow users to specify conntrack buffer size. #1896

tomwilkie commented Sep 26, 2016

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

2opremio commented Sep 26, 2016

2opremio commented Sep 26, 2016

This comment was marked as abuse.

This comment was marked as abuse.

rade left a comment

tomwilkie commented Sep 27, 2016

@rade commented on this pull request.

Allow users to specify conntrack buffer size. #1896

Allow users to specify conntrack buffer size. #1896

Conversation

tomwilkie commented Sep 26, 2016

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

2opremio commented Sep 26, 2016

2opremio commented Sep 26, 2016

This comment was marked as abuse.

This comment was marked as abuse.

rade left a comment

Choose a reason for hiding this comment

tomwilkie commented Sep 27, 2016

@rade commented on this pull request.