-
Notifications
You must be signed in to change notification settings - Fork 712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makes services the initial topology if available #1823
Conversation
The prioritisation should be services -> deployments -> replica sets -> pods -> containers. Says @tomwilkie. |
Cool, will update |
// | ||
// top priority first | ||
// | ||
const TOPOLOGY_DISPLAY_PRIORITY = [ |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
Code looks good. Implementation-nit: priority should be driven by backend, so that when new topos are added, UI does not have to be involved. UX-nit: If Services is the most important one, it should be at the top. Any introduction of priority ordering trumps representation model ordering (lower topos are groupings of higher topos). This needs to be changed in the backend. |
Actually, we should put this up for discussion in the next meeting. |
e7c062c
to
143939a
Compare
If we cant completely flip the order, I'd say let's stick to the original one. |
Node type, followed by its aggregates in order of most interest breaks strict "spatial alignment" w/ the priorities we've set up but I think it still works. If no aggs fall back to basic type. |
I mostly have a problem with a sub-menu entry being the most important one (decided by priority). I feel that it makes the menu harder to grok. |
- Otherwise reverts to containers
- Show something from k8s by default if its around.
47138a1
to
343a986
Compare
Fixes #1809