Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename NewReport -> MakeReport #181

Merged
merged 1 commit into from
Jun 5, 2015
Merged

Rename NewReport -> MakeReport #181

merged 1 commit into from
Jun 5, 2015

Conversation

tomwilkie
Copy link
Contributor

Depends on #178 & #180

@peterbourgon
Copy link
Contributor

This PR includes both of those, correct?

@tomwilkie
Copy link
Contributor Author

Yes as it depends on them. I won't submit this until they are submitted, so eventually it'll just have one.

Conversely, I could rebase this against master and get it in before #178 if that makes it easier for you?

@peterbourgon
Copy link
Contributor

If you can merge #178 and #180, I'll review this with the proper diff.

@tomwilkie tomwilkie force-pushed the rename-new-report branch from 40940ad to 754eac3 Compare June 5, 2015 13:55
@tomwilkie
Copy link
Contributor Author

I've merged #180 already, so here is this off master; no dependancies.

@peterbourgon
Copy link
Contributor

LGTM

@peterbourgon peterbourgon removed their assignment Jun 5, 2015
tomwilkie added a commit that referenced this pull request Jun 5, 2015
@tomwilkie tomwilkie merged commit bbc384a into master Jun 5, 2015
@tomwilkie tomwilkie deleted the rename-new-report branch June 5, 2015 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants