Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tighter node bounding boxes #1756

Merged
merged 4 commits into from
Aug 5, 2016
Merged

Tighter node bounding boxes #1756

merged 4 commits into from
Aug 5, 2016

Conversation

foot
Copy link
Contributor

@foot foot commented Aug 4, 2016

Fixes #1520

foot added 3 commits August 4, 2016 17:36
@foot
Smaller node bounding boxes for onHover/onClick
bf8d8a8 
foreignObject was huge on firefox.
@foot
Fixes foreignObject preventing other nodes from receiving hover
d786a07
@foot
Header no longer prevents node hover/click
bf8791b 
This introduces an inverse thingy, whenever you add something to the
header you have to be aware that by default you won't get any pointer
events and that you'll have to enable them for the dom elements you
wanna make interactive.
@rade
Copy link
Member

rade commented Aug 4, 2016

This does seem indeed seem to work.

davkal
davkal reviewed Aug 5, 2016
View reviewed changes
client/app/styles/main.less
@@ -165,6 +165,8 @@ h2 {
}

.header {
pointer-events: none;

This comment was marked as abuse.

Sign in to view

@davkal
Copy link
Contributor

davkal commented Aug 5, 2016

LGTM

@davkal davkal merged commit 74efec8 into master Aug 5, 2016
@davkal davkal deleted the tighter-node-bounding-boxes-1520 branch August 5, 2016 11:34
@davkal davkal mentioned this pull request Aug 5, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@davkal davkal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@foot @rade @davkal