Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 0.16.0 #1587

Merged
merged 5 commits into from
Jun 17, 2016
Merged

Release 0.16.0 #1587

merged 5 commits into from
Jun 17, 2016

Conversation

2opremio
Copy link
Contributor

No description provided.

rade
rade reviewed Jun 15, 2016
View reviewed changes
CHANGELOG.md
[#1582](https://github.com/weaveworks/scope/pull/1582)

Internal improvements and cleanup:
- Add Indentity middleware

This comment was marked as abuse.

Sign in to view

@rade
Copy link
Member

rade commented Jun 15, 2016

I don't see #1551 mentioned, which a user stumbled across only today.

@2opremio
Copy link
Contributor Author

@rade I incorporated it later, our CHANGELOG generator script wasn't detecting the new squashed merges properly.

rade
rade reviewed Jun 15, 2016
View reviewed changes
CHANGELOG.md
[#1551](https://github.com/weaveworks/scope/pull/1551)
- If k8s objects only have one container, show that container's metrics on them
[#1473](https://github.com/weaveworks/scope/pull/1473)
- Don't every store NEW conntrack flows (only every store updates).

This comment was marked as abuse.

Sign in to view

@rade
Copy link
Member

rade commented Jun 15, 2016 •
edited
Loading

About 25% of the items end in a full stop; the others don't. Is there a rationale?

rade
rade reviewed Jun 15, 2016
View reviewed changes
CHANGELOG.md

Highlights:

* New network view to quickly ascertain what networks your containers belong to.

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

@2opremio
Copy link
Contributor Author

2opremio commented Jun 16, 2016 •
edited
Loading

About 25% of the items end in a full stop; the others don't. Is there a rationale?

Items are auto-generated from PR titles, so no rationale. To be honest I don't think it's very important (and it's been inconsistent in previous releases). If we really really want to fix this, we should test PR titles or be strict about them in reviews.

@rade
Copy link
Member

rade commented Jun 16, 2016

To be honest I don't think it's very important

it isn't.

@2opremio 2opremio changed the title [WIP] Release 0.16.0 Release 0.16.0 Jun 17, 2016
@2opremio
Copy link
Contributor Author

2opremio commented Jun 17, 2016 •
edited
Loading

@jml @foot @davkal Please test. I need a LGTM from all of you before releasing (which I would like to do in less than two hours from now if everything goes well).

@2opremio
Copy link
Contributor Author

@pidster you too please

@2opremio 2opremio mentioned this pull request Jun 17, 2016
Closed
@2opremio
Copy link
Contributor Author

2opremio commented Jun 17, 2016 •
edited
Loading

I've tested:

  1. The ECS guide
  2. Scope monitoring our Kubernetes-based service when running locally
  3. A scope probe attached to cloud.weave.works while running (2)

I found #1598 when testing (2) but I don't have evidence of it being part of 0.16 (plus I wouldn't say it's a blocker)

Also, we should upgrade the service to support new app-side features like #1597

@davkal
Copy link
Contributor

davkal commented Jun 17, 2016

LGTM

@foot
Copy link
Contributor

foot commented Jun 17, 2016

LGTM!

@pidster
Copy link
Contributor

pidster commented Jun 17, 2016

LGTM

@jml
Copy link
Contributor

jml commented Jun 17, 2016

I abstain.

@2opremio 2opremio merged commit 588172f into master Jun 17, 2016
@2opremio 2opremio deleted the release-0.16 branch June 17, 2016 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@2opremio @rade @davkal @foot @pidster @jml