Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tall search box in Firefox #1583

Merged
merged 1 commit into from
Jun 14, 2016
Merged

Fix tall search box in Firefox #1583

merged 1 commit into from
Jun 14, 2016

Conversation

davkal
Copy link
Contributor

@davkal davkal commented Jun 14, 2016

  • FF has an issue with flexbox and set width
  • setting flex only when focused
  • downside is that there is a small jump to 2 rows when expanding the box in FF

* FF has an issue with flexbox and set width
* setting flex only when focused
@foot
Copy link
Contributor

foot commented Jun 14, 2016

You do get a "flash-of-tallness" on focus. Which is a little distracting but still better than before.

Removing the flex-wrap fixes this too but might be breaking another edge case?

diff --git a/client/app/styles/main.less b/client/app/styles/main.less
index da5f5d8..417947d 100644
--- a/client/app/styles/main.less
+++ b/client/app/styles/main.less
@@ -1260,7 +1260,6 @@ h2 {
     border: @search-border-width solid @search-border-color;
     padding: 2px 4px;
     text-align: left;
-    flex-wrap: wrap;

     &-field {
       font-size: 0.8rem;

Edit: You mentioned the flashoftallness I didn't read the description v.well the first time.

@foot foot assigned davkal and unassigned foot Jun 14, 2016
@davkal
Copy link
Contributor Author

davkal commented Jun 14, 2016

Here is the edge case:

screen shot 2016-06-14 at 17 27 50

Pinned searches are supposed to wrap.

@davkal davkal merged commit e2050e1 into master Jun 14, 2016
@davkal davkal deleted the 1518-tall-search branch June 14, 2016 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants