Put reports in S3; add in process caching #1545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 tasks
|
I would suggest that, as soon as you have several replicas, the cache hit rate will be very low. |
tomwilkie
changed the title
|
As discussed, I've put reports into s3 now.
Agreed. I'll add an (optional) external, shared memcache for reports. I'd prefer to do this in the next PR as there a quite a few outstanding changes. WDYT? Also, any recommendations re:flags? It feels a bit clunky right now, esp. given we're about to add memcache too. |
| reportSize = prometheus.NewCounter(prometheus.CounterOpts{ | ||
| Namespace: "scope", | ||
| Name: "report_size_bytes", | ||
| Help: "Size of reports written to s3.", |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
@paulbellamy I can haz LGTM? |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.