Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network view #1528

Merged
merged 12 commits into from
Jun 6, 2016
Merged

Network view #1528

merged 12 commits into from
Jun 6, 2016

Conversation

foot
Copy link
Contributor

@foot foot commented May 19, 2016

Initial implementation of the network view.

It will follow the established UI convention of the details panel.

  1. Hover over a "Networks" overlay button to show networks.
  2. Clicking the "Networks" overlay button to show and pin all networks and reveal a legend w/ network names listed.
  3. Hover over individual networks labels to fade out nodes that are not included in that network.
  4. Click individual networks to open the details panel w/ network info and pin the faded/highlighted nodes states. v2
  5. Clicking the nodes should overlay an additional details panel that can be popped to return the network details.
  • Add coloured circle segments to a node that represents network membership.
  • click legend item to show details panel showing network details. v2
  • style legend w/ colors
  • Allow enable/disabled network-arc overlays (maybe by expanding the legend).
  • highlight networks members on legend item hover (or fade others)
  • include net-view state in url state

stretch

  • add a collapsed state to the legend.

@davkal davkal mentioned this pull request May 25, 2016
@foot
Copy link
Contributor Author

foot commented Jun 2, 2016

Design RC: netview

@foot
Copy link
Contributor Author

foot commented Jun 2, 2016

Report to test w/ tnscompose.json.zip

@foot foot assigned foot and davkal and unassigned foot Jun 2, 2016
const r = size * 0.5;
const offset = r + labelOffset;
const w = Math.max(size, (size / 4) * networks.size);
const x = d3.scale.ordinal()

This comment was marked as abuse.

This comment was marked as abuse.

@davkal
Copy link
Contributor

davkal commented Jun 2, 2016

Visual:

screen shot 2016-06-02 at 12 05 35
The underlines are flush against "Networks" which looks a bit abrupt. Have you tried underlining "Networks" in neutral color?

screen shot 2016-06-02 at 12 10 32
Could we make this not overlap?

screen shot 2016-06-02 at 12 13 00
Could this be ameliorated?

screen shot 2016-06-02 at 12 14 27
Negligible edge case?

JS Code looks good.

My comment re data still applies:

       // TODO move this setting of networks as toplevel node field to backend,
       // to not rely on field IDs here. should be determined by topology implementer
       state = state.update('nodes', nodes => nodes.map(node => {
         if (node.has('metadata')) {
           const networks = node.get('metadata')
             .find(field => field.get('id') === 'docker_container_networks');
           if (networks) {
             return node.set('networks', fromJS(
               networks.get('value').split(', ').map(n => ({id: n, label: n, colorKey: n}))));
           }
         }
         return node;
       }));

@davkal davkal assigned foot and unassigned davkal Jun 2, 2016
foot and others added 10 commits June 6, 2016 16:23
Needs a bit of de-dup / customization

oops, bad typo

More fleshing out the structure for network-view

onHover netview-legend: highlight relevant nodes.

And the bool rolls on.

Handle nodes w/ no networks better

Corrects deselect-node when used w/ new network-view behaviour

Net view details "node" can be open when with no nodes selected. Hitting
"esc" from:
 - card 0: network-a
 - card 1: node-a
was not deselecting node-a

Deselect selectedNetwork correctly onEsc

Ooops, trailing ws breaks linting.

Adds NodeNetworksOverlay stub

Expands on NodeNetworksOverlay stub and adds arcs and colors

Expand and collapse networks legend

Open arc for network circle, shift for stack

Show our base hue range in the debug bar too..

Was trying to smooth out our hue selector but turned out to be tricky..

Uniquify random data generator!
Testing out colored borders rather than BGs for net-view legend
Fixes edge focus/blurring when selecting networks

Configurable arc size

net-view variant: Smaller arc (just the top)

net-view revision: Add white container around arcs.

To join them together in a sense. Trying to avoid the edge/arc position
association. Not sure if this really helps

net-view variations: shadows.

bg fill, align network rotation w/ rank.

Cute little dots

Stacked lines

Rounded rects

Slightly thicker "pills" to repr networks

Handle edge case by making line longer

Fix network bar offset
@foot foot merged commit 7c4b7a5 into master Jun 6, 2016
@foot foot deleted the network-view branch June 6, 2016 15:03
@2opremio 2opremio changed the title [WIP] Network view Network view Jun 15, 2016
@rade rade mentioned this pull request Jul 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants