Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1507. Adding Marathon JSON for launching on minimesos cluster #1509

Merged
merged 4 commits into from
May 31, 2016
Merged

#1507. Adding Marathon JSON for launching on minimesos cluster #1509

merged 4 commits into from
May 31, 2016

Conversation

sadovnikov
Copy link
Contributor

See related #1507

@tomwilkie
Copy link
Contributor

@errordeveloper mind taking a look at this? You know mesos better than anyone.

@errordeveloper errordeveloper self-assigned this May 18, 2016
errordeveloper
errordeveloper reviewed May 18, 2016
View reviewed changes
examples/mesos/minimesos.json
"true"
],
"env": {
"CHECKPOINT_DISABLE": ""

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

errordeveloper
errordeveloper reviewed May 26, 2016
View reviewed changes
examples/mesos/README.md
@@ -0,0 +1,14 @@
# Launching Weave Scope on Apache Mesos Cluster

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

@sadovnikov
Copy link
Contributor Author

@errordeveloper I moved installation instructions to site/installing.md. Please, take a look

@errordeveloper
Copy link
Contributor

@sadovnikov thank you! I'd tweak the text a bit, @pidster what do you think?

@pidster
Copy link
Contributor

pidster commented May 31, 2016

@errordeveloper if it's factually correct, accept it as-is, and ask @abuehrle if she can check the phrasing and adjust as required.

@errordeveloper errordeveloper merged commit 1762cc4 into weaveworks:master May 31, 2016
@abuehrle abuehrle mentioned this pull request May 31, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@errordeveloper errordeveloper

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sadovnikov @tomwilkie @errordeveloper @pidster