Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blur search when opening a terminal #1499

Merged
merged 3 commits into from
May 13, 2016
Merged

Conversation

davkal
Copy link
Contributor

@davkal davkal commented May 12, 2016

No description provided.

@foot
Copy link
Contributor

foot commented May 12, 2016

Yeah I've been playing around w/ blurring a bit, the shortcuts don't works
unless the search field is properly blurred blurred which is an esc. I
popped an onBlur back on the field but then alt-tabbing was blurring, I
think a fix for both these might get quite involved.

On 12 May 2016 at 19:36, David [email protected] wrote:

Assigned #1499 #1499 to @foot
https://github.com/foot.


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#1499 (comment)

@tomwilkie tomwilkie added this to the 0.15.0 milestone May 12, 2016
@foot
Copy link
Contributor

foot commented May 13, 2016

Ah hah it was a PR! Need to read PR/Issue more carefully.

@foot
Copy link
Contributor

foot commented May 13, 2016

Testing...

@foot
Copy link
Contributor

foot commented May 13, 2016

Nice! Works much better:

Only small tweak, maybe move esc precedence up, so terminal closes before blurring/clearing search.

  1. search for something
  2. find it
  3. details
  4. terminal
  5. close terminal w/ c-d, esc
  6. return to search context

@foot
Copy link
Contributor

foot commented May 13, 2016

LGTM

@davkal davkal merged commit 2fac25d into release-0.15 May 13, 2016
@davkal davkal deleted the blur-search-on-terminal branch May 13, 2016 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants