Ignore conntracked connections on which we never saw an update #1466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shouldn't we only be paying attention to ESTABLISHED events? |
Yeah I thought about that, but the way it works it to buffer old flows that came and went during the reporting period. So those connections would never be ESTABLISHED. |
tomwilkie
force-pushed
the
1462-edge-direction
branch
from
b2e8221 to
281139a
Compare
tomwilkie
changed the title
tomwilkie
force-pushed
the
1462-edge-direction
branch
from
281139a to
84c58c3
Compare
| @@ -60,6 +60,10 @@ func (n natMapper) applyNAT(rpt report.Report, scope string) { | |||
| if !ok { | |||
| return | |||
| } | |||
| // Don't apply nat mappings to conntracked connections | |||
| if _, procspied := node.Latest.Lookup(Procspied); !procspied { | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
… nat map conntracked connections.
tomwilkie
force-pushed
the
1462-edge-direction
branch
from
84c58c3 to
3fda38b
Compare
|
LGTM |
errordeveloper
pushed a commit
that referenced
this pull request
May 11, 2016
… nat map conntracked connections. (#1466)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1462