Limit tables to 20 rows

[2opremio]

Should help with #1457 and #1454 until we have #985

[2opremio]

@davkal Here's a sample report with the new truncation field in place: report_truncation.json.gz

[rade]

What gets truncated by this besides container env vars?

[rade]

What gets truncated by this besides container env vars?

AFAICT it is

• docker image labels
• docker container labels
• k8s labels

[2opremio]

That is correct:

scope/probe$ grep -r AddTable *
docker/container.go:    result = result.AddTable(LabelPrefix, c.container.Config.Labels)
docker/container.go:    result = result.AddTable(EnvPrefix, c.env())
docker/reporter.go:             node = node.AddTable(ImageLabelPrefix, image.Labels)
kubernetes/meta.go:     }).AddTable(LabelPrefix, m.Labels())

[2opremio]

@davkal Looking good

Two comments:

• Can we make it so that the message is shown when clicking not just hover?
• Maybe the copy could be slightly refined.
  Currently: The section Environment Variables has been truncated because of too many entries.
  714 entries are not shown. We are working on making this better.

I would propose This section is too long and has been truncated (714 extra entries not included). We are working to remove this limitation.

I think it's more to the point and the section is obvious since it's name is right next to the warning sign.

[2opremio]

@paul @foot Can you PTAL ?

[paulbellamy]

I'd even drop We are working on making this better. Maybe just 714 entries hidden (which is all we say about filtered unconnected processes).

Maybe, yeah. I wouldn't use hidden or not displayed because it can cause confusion with the table expansion.

[paulbellamy]

backend code, LGTM.

[foot]

Code LGTM!

Copy about why we're truncating is kind of nice, explaining the situation a bit. But there are probably reasons not too. Like admission of imperfection in product or something.

I like

We are working to remove this limitation.

[foot]

Should host.process-list/container-list be getting truncated? Those are 500+ on the attached report and make the UI a bit janky.

[2opremio]

@foot That's tricker because ordering processes by CPU use etc ... require having them all to be useful.

[2opremio]

LGTM