Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't merge nodes in the rendering pipeline #1398

Merged
merged 1 commit into from
May 3, 2016
Merged

Conversation

tomwilkie
Copy link
Contributor

Fixes #1212

This make an almost 50% reduction in the cost of the rendering pipeline, reduces memory usage by 20% and makes a big difference to garbage load.

Unfortunately is breaks everything. So we need to fix that....

@tomwilkie tomwilkie self-assigned this Apr 28, 2016
@tomwilkie tomwilkie changed the title [WIP] Don't merge nodes in the rendering pipeline Don't merge nodes in the rendering pipeline May 3, 2016
@tomwilkie
Copy link
Contributor Author

@paulbellamy I think this should all work now. PTAL

@tomwilkie tomwilkie assigned paulbellamy and unassigned tomwilkie May 3, 2016
}
if hostNodeID, timestamp, ok := node.Latest.LookupEntry(report.HostNodeID); ok {
output.Latest = output.Latest.Set(report.HostNodeID, timestamp, hostNodeID)
}

This comment was marked as abuse.

This comment was marked as abuse.

@paulbellamy
Copy link
Contributor

Having read over it in more depth, and understood stuff a bit better, I think I prefer having the propagation of HostNodeID in MapContainer2Pod (the only place it's needed), with a comment saying why. Same for IsConnected in MapProcess2Container (if that's the only place it is needed?).

That way it's more explicit, and "obvious" where/why we're doing this.

@paulbellamy
Copy link
Contributor

Everywhere we use ProcessRenderer we wrap it in a ColorConnected(ProcessRenderer). With this change, we might be able to move the ColorConnected into the definition of ProcessRenderer, so it is always included.

We depend on it in render/detailed/summary.go:196, to determine if a process is "linkable" so (if possible) it would be very good to have consistency there, and make sure we don't "miss" it anywhere.

@tomwilkie
Copy link
Contributor Author

@paulbellamy PTAL?

@paulbellamy paulbellamy merged commit f2546dc into master May 3, 2016
@paulbellamy paulbellamy deleted the 1212-whitelist branch May 3, 2016 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Whitelist metadata/metrics let through MapX2Y converters
2 participants