Filter by Kubernetes Namespaces #1386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Per f2f discussion, (a) sounds better. |
|
Blocked on #1371 |
paulbellamy
force-pushed
the
1340-k8s-filter-namespace
branch
3 times, most recently
from
603aa7b to
23fdf47
Compare
|
@tomwilkie probably worth having a look at this. It is still showing the wrong node-count for services (it's showing the pod node count), but... |
|
Also, we should filter out delete pods/services when figuring out the available namespaces. |
paulbellamy
force-pushed
the
1340-k8s-filter-namespace
branch
from
5427a26 to
64c9ff6
Compare
paulbellamy
changed the title
|
@tomwilkie, ptal |
| return r.rendererForTopology(mux.Vars(req)["topology"], values, rpt) | ||
| } | ||
|
|
||
| func captureReporter(rep Reporter, f reportRenderHandler) CtxHandlerFunc { |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
| func(n report.Node) bool { | ||
| // Drop deleted or empty pods | ||
| state, ok := n.Latest.Lookup(kubernetes.PodState) | ||
| return HasChildren(report.Container)(n) && (!ok || state != kubernetes.StateDeleted) |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
paulbellamy
force-pushed
the
1340-k8s-filter-namespace
branch
from
3371060 to
2d7df7c
Compare
paulbellamy
force-pushed
the
1340-k8s-filter-namespace
branch
from
2d7df7c to
0e70f70
Compare
|
LGTM (assuming green) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1340
Won't really work in multitenant, as the topologyRegistry shouldn't
change. We need to apply it transiently on each call, on a per-report
basis.
Options are:
a) replace topologyRegistry.walk() with topologyRegistry.Topologies(),
and then modify them, in renderTopologies.
b) make APITopologyDesc.Options a func(report.Report)
[]APITopologyOptionGroup, and call that from renderTopologies.
@tomwilkie, any thoughts? preferences?