Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change url encoding to handle multiple slashes in node names #1346

Merged
merged 1 commit into from
Apr 19, 2016
Merged

Change url encoding to handle multiple slashes in node names #1346

merged 1 commit into from
Apr 19, 2016

Conversation

foot
Copy link
Contributor

@foot foot commented Apr 19, 2016

Fixes #1335

@foot
Copy link
Contributor Author

foot commented Apr 19, 2016

To test create a "bad" node w/:

docker run -dit -e MARATHON_APP_ID=/foo/zing --name foo2 alpine /bin/sh

Then select it in a scope so its details are displayed, check the state in the url, then hit reload to make sure it doesn't redirect.

@davkal
Copy link
Contributor

davkal commented Apr 19, 2016

LGTM

@davkal davkal assigned foot and unassigned davkal Apr 19, 2016
@foot foot merged commit 693c40c into master Apr 19, 2016
@foot foot deleted the 1335-nodes-with-a-slash branch April 19, 2016 15:57
errordeveloper pushed a commit to errordeveloper/scope that referenced this pull request Apr 22, 2016
@foot @errordeveloper
Merge pull request weaveworks#1346 from weaveworks/1335-nodes-with-a-…
8c8310e 
…slash

Change url encoding to handle multiple slashes in node names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@foot foot

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@foot @davkal