Add explicit group node summariser instead of doing it in the other summaries #1327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulbellamy
force-pushed
the
1213-group-summariser
branch
from
2b330d3 to
c17c7c7
Compare
| report.ContainerImage: Hexagon, | ||
| render.Pseudo: Cloud, | ||
| } | ||
| ) |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
LGTM with some minor comments. |
paulbellamy
force-pushed
the
1213-group-summariser
branch
from
c17c7c7 to
d99dd4f
Compare
paulbellamy
force-pushed
the
1213-group-summariser
branch
from
d99dd4f to
9f652ee
Compare
paulbellamy
force-pushed
the
1213-group-summariser
branch
2 times, most recently
from
9697b18 to
c645e51
Compare
paulbellamy
force-pushed
the
1213-group-summariser
branch
from
c645e51 to
99c611f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1213