Set the memory and open files maximums based on the host

[paulbellamy]

Fixes #1149

Now the max on Memory, and Open Files metrics are set based on the host.

However, it seems like the sparklines don't use the max value? @davkal @foot ?

[foot]

I think so... 2x checking.

On Tuesday, April 5, 2016, Paul Bellamy [email protected] wrote:

Fixes #1149 #1149

Now the max on Memory, and Open Files metrics are set based on the host.

However, it seems like the sparklines don't use the max value? @davkal

https://github.com/davkal @foot https://github.com/foot ?

You can view, comment on, or merge this pull request online at:

#1225
Commit Summary

• Set the memory and open files maximums based on the host

File Changes

• M probe/docker/container.go
  https://github.com/weaveworks/scope/pull/1225/files#diff-0 (2)
• M probe/docker/container_test.go
  https://github.com/weaveworks/scope/pull/1225/files#diff-1 (3)
• M probe/process/reporter.go
  https://github.com/weaveworks/scope/pull/1225/files#diff-2 (53)
• M probe/process/reporter_test.go
  https://github.com/weaveworks/scope/pull/1225/files#diff-3 (6)
• M prog/probe.go
  https://github.com/weaveworks/scope/pull/1225/files#diff-4 (8)

Patch Links:

• https://github.com/weaveworks/scope/pull/1225.patch
• https://github.com/weaveworks/scope/pull/1225.diff

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#1225

[foot]

You are right, we're taking the max of the samples I think, which might be more appropriate for sparklines? I will try w/ real max soon.

But this works great on MoC! Awesome stuff, LGTM from a behavioural POV

[paulbellamy]

Ok, I updated this to get per-process File limit and memory limits. Unfortunately, the memory limits are not cgroup aware (because the /proc/<pid>/stat is not cgroup aware). Apparently to do that you have to parse the cgroups and mount files, and dig through the cgroup file system, so I'll create a separate issue for that.

[foot]

Updated js code to use openfiles.max.

Proc -> Container memory doesn't seem to "add up", e.g.
sum(proc.mem_usage) > container.mem_usage.
But I don't think thats a regression!

LGTMTM.