Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests for Consul Pipe Router. #1209

Merged
merged 2 commits into from
Apr 12, 2016
Merged

Tests for Consul Pipe Router. #1209

merged 2 commits into from
Apr 12, 2016

Conversation

tomwilkie
Copy link
Contributor

Various fixes (mainly to how stuff is shutdown) and a test for the consul pipe router.

  • Don't share a pointer in consul client
  • Wait for the actor thread to make the pipe before returning it.
  • Ensure every shutsdown correctly
  • Make logging more consistent

@tomwilkie tomwilkie force-pushed the multitenant-tests branch 2 times, most recently from 324d929 to 9a0d855 Compare April 12, 2016 13:22
@tomwilkie tomwilkie changed the title [WIP] Tests for Consul Pipe Router. Tests for Consul Pipe Router. Apr 12, 2016
@tomwilkie
Tests & vartious fixes for consul pipe router.
da53aac 
Fix a few bugs in the consul pipe router:
- Don't share a pointer
- Write nil to pipe when closing a bridge connection to ensure the connection shutdown.
- Ensure we shutdown bridge connections correctly
@paulbellamy paulbellamy merged commit dc0165a into master Apr 12, 2016
@paulbellamy paulbellamy deleted the multitenant-tests branch April 12, 2016 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomwilkie @paulbellamy