React/lodash/babel upgrades + updated linting (linted) #1171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
davkal
commented
Mar 15, 2016
davkal
commented
- important upgrades: react to 0.14.7, react-motion 0.4, jest 0.9, lodash 4.6, babel 6.5
- linter rules upgraded, linted JS
- fixes edge highlighting on node hover
davkal
changed the title
|
Nice one! All seems to be working! It feels like we've introduced a bit of a perf hit. E.g. when selecting a node the animation is suffering a bit there. And dragging the canvas around a little. Perhaps the Obj.assigns? But we can work through that along w/ the pure mixins. LGTM |
davkal
added a commit
that referenced
this pull request
Mar 16, 2016
React/lodash/babel upgrades + updated linting (linted)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.