Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base work for #1105 and #1159
Could use more refactoring eventually, as the RenderableNode json rendering is never really used after this. We either render the NodeSummary or the detailed.Node. Might also be worth splitting
detailed
andsummary
into different packages, but that will conflict with changes in #1126.With this change the topology views (and deltas) include the nodes' metadata and metrics (sans samples). e.g.
@tomwilkie, wdyt?