Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More complete node summary #1169

Closed
wants to merge 5 commits into from
Closed

Conversation

paulbellamy
Copy link
Contributor

Base work for #1105 and #1159

Could use more refactoring eventually, as the RenderableNode json rendering is never really used after this. We either render the NodeSummary or the detailed.Node. Might also be worth splitting detailed and summary into different packages, but that will conflict with changes in #1126.

With this change the topology views (and deltas) include the nodes' metadata and metrics (sans samples). e.g.

{ nodes: [
  process:scope:1716: {
    id: "process:scope:1716",
    label: "/home/weave/weaver",
    label_minor: "scope (weave:1716)",
    rank: "/home/weave/weaver",
    shape: "square",
    linkable: true,
    metadata: [
      {
        id: "threads",
        label: "# Threads",
        value: "12",
        prime: true
      },
      ...
    ],
    metrics: [
      {
        id: "process_memory_usage_bytes",
        label: "Memory",
        format: "filesize",
        value: 46587904,
        samples: [ ],
        min: 0,
        max: 46587904,
        first: "2016-03-15T12:00:58.106201326Z",
        last: "2016-03-15T12:01:12.065987896Z"
      },
      ...
    ]
  }
]}

@tomwilkie, wdyt?

@paulbellamy paulbellamy force-pushed the more-complete-node-summary branch 2 times, most recently from 8e667e7 to efeb223 Compare March 17, 2016 15:04
@paulbellamy paulbellamy mentioned this pull request Mar 23, 2016
1 task
@tomwilkie
Copy link
Contributor

Superceeded by #1204

@tomwilkie tomwilkie closed this Mar 24, 2016
@paulbellamy paulbellamy deleted the more-complete-node-summary branch March 29, 2016 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants