Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Show More buttons with carets w/ counts #1029

Merged
merged 2 commits into from
Feb 25, 2016
Merged

Replace Show More buttons with carets w/ counts #1029

merged 2 commits into from
Feb 25, 2016

Conversation

davkal
Copy link
Contributor

@davkal davkal commented Feb 24, 2016

screen shot 2016-02-24 at 18 59 47

@davkal davkal added the component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer label Feb 24, 2016
@foot
Copy link
Contributor

foot commented Feb 25, 2016

Little issues:

  1. Clicking on the minified load numbers next to the sparklines doesn't expand them
  2. If there is no cpu/mem in a table the whole row doesn't highlight on mouseover.
  3. With the +42 v off to the side the line becomes more prominent and feels "at-a-glance" to be more of a divider between sections, but a very unbalanced one (no margin-top and too much margin-bottom). But i've been playing w/ the diff combos. I think lhs/center/rhs all have strengths and weaknesses. I'm leaning a tiny bit more towards centered again but I you can arg for any of them really.

LGTM after 1 & 2!

@davkal
Copy link
Contributor Author

davkal commented Feb 25, 2016

If there is no cpu/mem in a table the whole row doesn't highlight on mouseover.

If there are no metrics, no td elements are generated, which the browser seem to need to make up a full row.

@foot
Copy link
Contributor

foot commented Feb 25, 2016

  ftw. I'm not that fussed. Still LGTM i think.

@pidster
Copy link
Contributor

pidster commented Feb 25, 2016

I concur, LGTM

davkal added a commit that referenced this pull request Feb 25, 2016
@davkal
Merge pull request #1029 from weaveworks/show-moar
5b5cb29 
Replace Show More buttons with carets w/ counts
@davkal davkal merged commit 5b5cb29 into master Feb 25, 2016
@davkal davkal deleted the show-moar branch February 25, 2016 13:03
@davkal
Copy link
Contributor Author

davkal commented Feb 25, 2016

Styled the show moar line to be dotted. Looks more subtle, and a bit less like a divider.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@foot foot

Labels
component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davkal @foot @pidster