Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gopacket seems to statically initialise a lot of memory... #466

Closed
tomwilkie opened this issue Sep 8, 2015 · 6 comments
Closed

gopacket seems to statically initialise a lot of memory... #466

tomwilkie opened this issue Sep 8, 2015 · 6 comments
Labels
tech-debt Unpleasantness that does (or may in future) affect development

Comments

@tomwilkie
Copy link
Contributor

heap

@tomwilkie tomwilkie added the tech-debt Unpleasantness that does (or may in future) affect development label Sep 8, 2015
@peterbourgon
Copy link
Contributor

Is this a problem?

@tomwilkie
Copy link
Contributor Author

Makes debugging the heap usage a little tougher, and seems like a shame
considering its not turned on by default.

On Mon, Sep 14, 2015 at 5:55 PM, Peter Bourgon [email protected]
wrote:

Is this an actual problem?


Reply to this email directly or view it on GitHub
#466 (comment).

@peterbourgon
Copy link
Contributor

Well, I guess the subtext to that question was "is there anything we can do about it" save forking and cleaning up gopacket?

@tomwilkie
Copy link
Contributor Author

An alternative would be to move the packet inspection code into a separate binary and only launch it when we enable that feature.

I think we probably want to do this for the tracer anyway (as its performance critical), so perhaps the same reasoning applies here?

@peterbourgon
Copy link
Contributor

I'm fine with ripping packet capture out of Scope. Failed experiment for the time being.

@tomwilkie
Copy link
Contributor Author

I wouldn't go that far just yet; its still a candidate for getting better metrics. Maybe move it to experimental? That will prevent some of the bit rot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech-debt Unpleasantness that does (or may in future) affect development
Projects
None yet
Development

No branches or pull requests

2 participants