Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pseudo nodes are unclickable #249

Closed
tomwilkie opened this issue Jun 16, 2015 · 7 comments
Closed

Pseudo nodes are unclickable #249

tomwilkie opened this issue Jun 16, 2015 · 7 comments
Assignees

Comments

@tomwilkie
Copy link
Contributor

Is this intentional?

@davkal
Copy link
Contributor

davkal commented Jun 16, 2015

we don't have any NodeMetadata for them, so nothing to render in the side panel

This was also my reasoning. Nothing to see there.
Under which circumstances is there any meta data?

@tomwilkie
Copy link
Contributor Author

Pseudo nodes in the containers view have a ton of metadata.

On Tuesday, 16 June 2015, David [email protected] wrote:

we don't have any NodeMetadata for them, so nothing to render in the side
panel

This was also my reasoning. Nothing to see there.
Under which circumstances is there any meta data?


Reply to this email directly or view it on GitHub
#249 (comment).

@peterbourgon
Copy link
Contributor

Pseudonodes are nodes we have to invent because we have them as a destination in an edge, but don't have any other data (metadata) for them. If a node has metadata, by definition it is not a pseudonode.

@tomwilkie
Copy link
Contributor Author

Are you suggesting uncontained should not be a pseudo node?

Note that even under you definition, we still have useful info we should
show the user - for instance, the Internet pseudo node has a mass be list
of ip addresses we could show, and other pseudo nodes has port numbers we
could show.

On Saturday, 20 June 2015, Peter Bourgon [email protected] wrote:

By definition pseudonodes are nodes we have to invent because we have them
as a destination in an edge, but don't have any other data (metadata) for
them. If a node has metadata, by definition it is not a pseudonode.


Reply to this email directly or view it on GitHub
#249 (comment).

@peterbourgon
Copy link
Contributor

Agh, uncontained. Right. For the record, we're abusing the pseudo flag for that one.

But, point taken. There's always going to be some information we can display, actually.

@davkal
Copy link
Contributor

davkal commented Jul 14, 2015

Which nodes in which topologies do not have any data?

I'm asking because we could show an actionable message like install a probe in the details panel in that case.

@tomwilkie
Copy link
Contributor Author

Not much in the process topology to show. And "the internet" never has any info. Really its only the uncontained node that has meaningful info I think. OTOH paul's recent connections stuff might work for all pseudo nodes...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants