Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stopped containers not shown with their names #1691

Closed
rade opened this issue Jul 17, 2016 · 3 comments
Closed

stopped containers not shown with their names #1691

rade opened this issue Jul 17, 2016 · 3 comments
Assignees
@rade
Labels
bug Broken end user or developer functionality; not working as the developers intended it
Milestone
0.17.0

Comments

@rade
Copy link
Member

rade commented Jul 17, 2016

Run

docker create --name=foo -ti alpine /bin/sh

and look at the stopped container in Scope. It is shown without the name.

This used to work not so long ago since I did my dockercon demo with stopped containers as the starting point.
@rade rade added bug Broken end user or developer functionality; not working as the developers intended it component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer labels Jul 17, 2016
@rade rade added this to the July2016 milestone Jul 17, 2016
@rade
Copy link
Member Author

rade commented Jul 18, 2016

This is fine in scope 0.14.0. Broken in 0.15.0.

@rade rade removed the component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer label Jul 21, 2016
@rade
Copy link
Member Author

rade commented Jul 21, 2016

This is not a UI issue. When a container is stopped the report no longer contains the docker_container_name.

@rade
Copy link
Member Author

rade commented Jul 21, 2016

This got broken by b78c503 - which removed ContainerName from getBaseNode(), because it can change, but failed to add it back unconditionally in GetNode(). @2opremio

@rade rade self-assigned this Jul 21, 2016
rade added a commit that referenced this issue Jul 21, 2016
@rade
show names of stopped containers
b3874e6 
This got broken in b78c503

Fixes #1691
@rade rade mentioned this issue Jul 21, 2016
Merged
rade added a commit that referenced this issue Jul 21, 2016
@rade
Merge pull request #1708 from weaveworks/1691-show-stopped-container-…
d0e5a14 
…name

show names of stopped containers

Fixes #1691
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rade rade

Labels
bug Broken end user or developer functionality; not working as the developers intended it
Projects
None yet
Milestone
0.17.0
Development

No branches or pull requests
1 participant
@rade